Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement secondary title #32

Open
wants to merge 1 commit into
base: MOODLE_400_STABLE
Choose a base branch
from

Conversation

kabalin
Copy link
Contributor

@kabalin kabalin commented Jul 24, 2022

This patch adds an option to section settings that allows defining secondary title. Secondary title will be displayed under the title in the section layout. This is useful when one is using weekly format and want to have a custom topic too (and summary is used for summary and needs to be distinguished from title):

image

@marinaglancy
Copy link
Owner

marinaglancy commented Nov 5, 2022

hi Ruslan, how is this secondary title different from the section description? It is not editable inline, it does not have any special styles. In the edit section form the "Secondary title" element is under the "Summary" element but when they are displayed, the "Secondary title" is above it.

I know that you can't change the order in this form but it makes this new field confusing for the user and does not have any benefits, at least in the current implementation

@kabalin kabalin force-pushed the new400-secondarytitle branch 2 times, most recently from 161fa02 to c4a2925 Compare November 20, 2022 20:24
@kabalin
Copy link
Contributor Author

kabalin commented Nov 20, 2022

Hello Marina, thanks for your time looking into this. You are right, it does not add value if duplicating summary functionality. The patch has been modified to show secondary title above the main one. This way it also stays visible when section is collapsed (summary element is not visible in this state).

image

@kabalin kabalin force-pushed the new400-secondarytitle branch from c4a2925 to d20df3e Compare June 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants