Better binary detection #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binary detection essentially looks at the first few characters and tries to determine whether they're ASCII characters which are appropriate for a DRAT proof. However, it forgot that newlines (0x0a) are ASCII characters which are appropriate for DRAT proofs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary detection essentially looks at the first few characters and
tries to determine whether they're ASCII characters which are
appropriate for a DRAT proof. However, it forgot that newlines (0x0a)
are ASCII characters which are appropriate for DRAT proofs.
A minimal example that used to fail, but now does not:
Formula:
Proof:
where the newline are 0x0a.