-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple unit tests for binary files #826
Conversation
To be merged before #825 |
Are these unit tests OS and CPU architecture independent?
This is the opposite what is in #825, could you edit one of your messages? |
They write and read. I will try to test it on windows to see what is breaking there. Unless you have the possibility now to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue seemed to be TemporaryFile not working properly on Windows because of missing assignment of file_
, which was not related to changes from the PR. After 3eca5ed, new unit tests pass.
Description
Add a few unit tests for binary files
Checklist