fix beam_search ABORT when enable openmp and OMP_NUM_THREADS > 1 #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amHypIdx??"); when enable openmp
update changelog
emjotde
approved these changes
Mar 23, 2021
|
Forgot about this one. |
This was referenced Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix beam_search ABORT_IF(beamHypIdx >= beam.size(), "Out of bounds beamHypIdx??"); when enable openmp and OMP_NUM_THREADS > 1
Description
Please add a clear and concise description of the changes.
This PR fixes a bug. When enable openmp and OMP_NUM_THREADS > 1, compiler is g++ 5.4, the swapAxes call in beam_search.h sometimes get wrong result. This can lead to abort with "Out of bounds beamHypIdx??", which is caused by activating an inactive beam.
List of changes:
Added dependencies: none
How to test
Describe how to test your changes, adding command line examples and sample input/output files if relevant.
Point to unit tests or regression tests covering the changes if they have been added.
Describe how you have tested your code, including OS and the cmake command.
Checklist