[CONJ-1053] Make the JPMS requirement on waffle-jna static

[A248]

The waffle-jna dependency is needed only when Windows GSSAPI authentication is used. In a previous commit, the static was incorrectly removed, making the dependency a hard requirement when running on JPMS.

5ac67b2

However, maven is not the same as JPMS. An optional dependency via Maven is not the same as requires static in JPMS. They serve entirely different purposes. By removing requires static, you are saying that all deployments must have waffle-jna present on the module path.

Re-adding requires static will not affect existing clients using MariaDB Connector-J. If they used waffla-jna before, they will continue to use it after this change.

https://jira.mariadb.org/browse/CONJ-1053

[piewie]

@A248 any reason why this is not merged yet? We stumble on this issue

[A248]

@piewie I'm not a maintainer. You could politely ask Diego Dupin (@rusher) or comment on the linked JIRA issue.

[Rottinator]

Is there any chance that this can be merged in near future? This is also something very annoying for us, having a lot of dependencies on our module path/class path we not really need, cause the dependency is not marked as requires static.

[rusher]

I'm on vacation, i'll look at that in a few weeks. @vaintroub what is tout point on it ?

[Rottinator]

@rusher Any news on this topic? :)