forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix (Expensify#37257): use instead of transition
- Loading branch information
1 parent
349e3b0
commit afcb123
Showing
4 changed files
with
14 additions
and
1 deletion.
There are no files selected for viewing
3 changes: 2 additions & 1 deletion
3
src/libs/Navigation/AppNavigator/modalStackNavigatorOptions/index.native.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
import type {NativeStackNavigationOptions} from '@react-navigation/native-stack'; | ||
import transition from './transition'; | ||
|
||
const defaultSubRouteOptions: NativeStackNavigationOptions = { | ||
headerShown: false, | ||
animation: 'slide_from_right', | ||
animation: transition, | ||
}; | ||
|
||
export default defaultSubRouteOptions; |
4 changes: 4 additions & 0 deletions
4
src/libs/Navigation/AppNavigator/modalStackNavigatorOptions/transition.android.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// `slide_from_right` is resolved to `default` transition on iOS, but this transition causes issues on iOS | ||
const transition = 'slide_from_right'; | ||
|
||
export default transition; |
5 changes: 5 additions & 0 deletions
5
src/libs/Navigation/AppNavigator/modalStackNavigatorOptions/transition.ios.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// default transition is causing weird keyboard appearance: - https://github.com/Expensify/App/issues/37257 | ||
// so we are using `simple_push` which is similar to default and not causing keyboard transition issues | ||
const transition = 'simple_push'; | ||
|
||
export default transition; |
3 changes: 3 additions & 0 deletions
3
src/libs/Navigation/AppNavigator/modalStackNavigatorOptions/transition.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
const transition = 'default'; | ||
|
||
export default transition; |