Skip to content

Commit

Permalink
fix (Expensify#37257): use instead of transition
Browse files Browse the repository at this point in the history
  • Loading branch information
kirillzyusko committed Mar 27, 2024
1 parent 349e3b0 commit afcb123
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import type {NativeStackNavigationOptions} from '@react-navigation/native-stack';
import transition from './transition';

const defaultSubRouteOptions: NativeStackNavigationOptions = {
headerShown: false,
animation: 'slide_from_right',
animation: transition,
};

export default defaultSubRouteOptions;
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// `slide_from_right` is resolved to `default` transition on iOS, but this transition causes issues on iOS
const transition = 'slide_from_right';

export default transition;
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// default transition is causing weird keyboard appearance: - https://github.com/Expensify/App/issues/37257
// so we are using `simple_push` which is similar to default and not causing keyboard transition issues
const transition = 'simple_push';

export default transition;
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
const transition = 'default';

export default transition;

0 comments on commit afcb123

Please sign in to comment.