remove notifications-common

FLPATH-755 https://issues.redhat.com/browse/FLPATH-755 Signed-off-by: Yaron Dayagi <[email protected]>
mareklibra · Nov 28, 2023 · 2e0332c · 2e0332c
1 parent 96216d4
commit 2e0332c
Show file tree

Hide file tree

Showing 11 changed files with 10 additions and 67 deletions.
diff --git a/plugins/notifications-backend/README.md b/plugins/notifications-backend/README.md
@@ -136,3 +136,7 @@ A user the notifications are filtered for, all targetUsers or targetGroups must
 Refer [Backstage documentation](https://backstage.io/docs/auth/) for details.
 
 For the purpose of development, there is `users.yaml` listing example data.
+
+## Building a client for the API
+
+We supply an Open API spec YAML file: openapi.yaml.
diff --git a/plugins/notifications-backend/package.json b/plugins/notifications-backend/package.json
@@ -27,7 +27,6 @@
     "@backstage/backend-common": "0.19.8",
     "@backstage/catalog-client": "^1.4.5",
     "@backstage/config": "^1.1.1",
-    "@backstage/plugin-notifications-common": "0.1.0",
     "@types/express": "*",
     "express": "^4.18.2",
     "express-promise-router": "^4.1.1",

diff --git a/plugins/notifications-backend/src/service/handlers.ts b/plugins/notifications-backend/src/service/handlers.ts
@@ -1,5 +1,9 @@
 /* eslint-disable func-names */
 import { CatalogClient } from '@backstage/catalog-client';
+
+import { Knex } from 'knex';
+
+import { ActionsInsert, MessagesInsert } from './db';
 import {
   CreateNotificationRequest,
   DefaultMessageScope,
@@ -13,11 +17,7 @@ import {
   NotificationsOrderByDirections,
   NotificationsOrderByFields,
   NotificationsSortingRequest,
-} from '@backstage/plugin-notifications-common';
-
-import { Knex } from 'knex';
-
-import { ActionsInsert, MessagesInsert } from './db';
+} from './types';
 
 // createNotification
 // returns string id of created notification

diff --git a/plugins/notifications-backend/src/service/router.ts b/plugins/notifications-backend/src/service/router.ts
@@ -1,7 +1,6 @@
 import { errorHandler } from '@backstage/backend-common';
 import { CatalogClient } from '@backstage/catalog-client';
 import { Config } from '@backstage/config';
-import { NotificationsSortingRequest } from '@backstage/plugin-notifications-common';
 
 import express from 'express';
 import Router from 'express-promise-router';
@@ -14,6 +13,7 @@ import {
   getNotificationsCount,
   setRead,
 } from './handlers';
+import { NotificationsSortingRequest } from './types';
 
 interface RouterOptions {
   logger: Logger;

diff --git a/plugins/notifications-common/src/types.ts → ...otifications-backend/src/service/types.ts b/plugins/notifications-common/src/types.ts → ...otifications-backend/src/service/types.ts
diff --git a/plugins/notifications-common/.eslintrc.js b/plugins/notifications-common/.eslintrc.js
diff --git a/plugins/notifications-common/README.md b/plugins/notifications-common/README.md
diff --git a/plugins/notifications-common/package.json b/plugins/notifications-common/package.json
diff --git a/plugins/notifications-common/src/index.ts b/plugins/notifications-common/src/index.ts
diff --git a/plugins/notifications-common/tsconfig.json b/plugins/notifications-common/tsconfig.json
diff --git a/plugins/notifications-common/turbo.json b/plugins/notifications-common/turbo.json