Add types to array2HashByKey #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaycle
commented
Jul 4, 2018
| return arr.reduce<ObjOfObjs<T>>( | ||
| (ordered, el) => { | ||
| if (el[key] in ordered) { | ||
| ordered[el[key]].push(el); |
There was a problem hiding this comment.
Spread didn't work. Maybe with microsoft/TypeScript#13288 but not sure. I tested this and it works well though.
jaycle
commented
Jul 5, 2018
| @@ -16,6 +12,6 @@ export const array2HashByKey = <T extends HasString<K>, K extends keyof T & stri | |||
| } | |||
| return ordered; | |||
| }, | |||
| {} | |||
| {} as {[key in string]: T[]} | |||
There was a problem hiding this comment.
Just moved the type here instead. Do you think explicitly naming it was better?
jaycle
commented
Jul 7, 2018
| {} | ||
| ); | ||
| }; | ||
| export const array2HashByKey = <T extends Record<K, string>, K extends keyof T>(arr: T[], key: K) => ( |
There was a problem hiding this comment.
Does there need to be a blank line here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.