Upgrade to nv-i18n 1.29 (closes #87)

marcwrobel · Mar 25, 2022 · 38d746c · 38d746c
1 parent fab87b7
commit 38d746c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,5 +18,6 @@ This new release…
 ## Internal
 
 - Upgrade to guava 31.1-jre (#86).
+- IsoCountryTest.
 
 ### Thanks
diff --git a/pom.xml b/pom.xml
@@ -20,7 +20,7 @@
     <this.java.version>1.8</this.java.version>
 
     <guava.version>31.1-jre</guava.version>
-    <nv-i18n.version>1.28</nv-i18n.version>
+    <nv-i18n.version>1.29</nv-i18n.version>
     <strata.version>2.9.4</strata.version>
   </properties>
 

diff --git a/src/test/java/fr/marcwrobel/jbanking/IsoCountryTest.java b/src/test/java/fr/marcwrobel/jbanking/IsoCountryTest.java
@@ -113,8 +113,13 @@ void ensureCompleteness() {
                 c ->
                     !EnumSet.of(
                             CountryCode.UNDEFINED,
-                            CountryCode.XI // https://github.com/marcwrobel/jbanking/issues/68
-                            )
+                            // XI and XU are not official ISO 3166 country codes and are mainly for
+                            // customs declarations (see
+                            // https://www.uktradeinfo.com/news/changes-to-country-and-commodity-codes-in-2022/). They are not
+                            // listed in IBAN registry. So they will not be added to the IsoCountry
+                            // enum.
+                            CountryCode.XI,
+                            CountryCode.XU)
                         .contains(c))
             .filter(c -> assignments.contains(c.getAssignment()))
             .collect(Collectors.toList());