Skip to content

Commit

Permalink
Remove deprecated methods (closes #49)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcwrobel committed Oct 17, 2020
1 parent c48b7a2 commit 0e0c268
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 27 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

This new release includes :
- serialization support,
- calendar API improvements (composite calendars),

This new release also includes breaking changes :
- deprecated methods removal (see details below).

### Added

Expand All @@ -20,4 +25,10 @@ This new release includes :

### Deprecated

### Removed

- Remove deprecated method `IsoCountry.getCode()` : use `IsoCountry.getAlpha2Code()` instead (#49).
- Remove deprecated method `IsoCountry.fromCode(String)` : use `IsoCountry.fromAlpha2Code(String)`
instead (#49).

### Thanks
27 changes: 0 additions & 27 deletions src/main/java/fr/marcwrobel/jbanking/IsoCountry.java
Original file line number Diff line number Diff line change
Expand Up @@ -805,18 +805,6 @@ public enum IsoCountry {
this(alpha2Code, alpha3Code, numericCode, true, null);
}

/**
* Returns this country ISO 3166-1-alpha-2 code.
*
* @deprecated use {@link #getAlpha2Code()}, will be removed in the next major version
* @return a non null and 2 characters length string.
* @see #getAlpha2Code()
*/
@Deprecated
public String getCode() {
return getAlpha2Code();
}

/**
* Returns this country ISO 3166-1 alpha-2 code.
*
Expand Down Expand Up @@ -910,21 +898,6 @@ public Set<Agreement> participations() {
return agreements;
}

/**
* Translate the given ISO 3166-1-alpha-2 code to an IsoCountry.
*
* <p>This method is not case-sensitive.
*
* @param code A non-null String.
* @deprecated use {@link #fromAlpha2Code(String)}, will be removed in the next major version
* @return the country having the given ISO 3166-1-alpha-2 code, or null if it does not exist.
* @see #fromAlpha2Code(String)
*/
@Deprecated
public static IsoCountry fromCode(String code) {
return fromAlpha2Code(code).orElse(null);
}

/**
* Translate the given ISO 3166-1 alpha-2 code to an IsoCountry.
*
Expand Down

0 comments on commit 0e0c268

Please sign in to comment.