Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a popup field to edit the default message #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bryanoliveira
Copy link

For my use case, I need to quickly edit the default message before sending it to a list of numbers. Therefore I added a message field in the popup to edit the message that was set in the options without saving it.

If you think that's useful for the extension in general, feel free to pull the changes or suggest other ways to do it.

@marcosvrs
Copy link
Owner

Thanks for your contribution!

I like the idea, but my only concern is that adding this directly to the popup might make it too large. What if we included this field in a collapsible section within the popup?
The main idea of having the message configuration under settings was indeed to save space on the popup, but I'm open to finding a balance that could work for all users.

Let me know your thoughts on this approach, or if you have other suggestions for implementation. Looking forward to further discussion!

@marcosvrs marcosvrs force-pushed the master branch 7 times, most recently from 39008fa to 14fa50b Compare July 2, 2023 18:02
@marcosvrs marcosvrs force-pushed the master branch 4 times, most recently from fd1705b to 8971e90 Compare June 23, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants