Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable tests (doctests failure) (#95) #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blackheaven
Copy link
Contributor

I have completely disable tests (it's usually done for other haskell packages with doctests) which makes the build to pass, however, we lost nix build safety.

I can investigate further to only disable the check of the lhs file.

Copy link
Owner

@marcosh marcosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This does not actually solves the issue, but it just avoids it, right?

It could be a temporary solution, but it would be nice to solve the actual issue

flake.nix Outdated Show resolved Hide resolved
@blackheaven
Copy link
Contributor Author

It could be a temporary solution, but it would be nice to solve the actual issue

It would take an upstream fix (my guess is lhs files are relying on GHCi and flags aren't properly set).

If you want, I can work on a less invasive solution: disabling only doctests, or avoiding lhs.

Let me know what would be better.

@marcosh
Copy link
Owner

marcosh commented Oct 10, 2024

It could be a temporary solution, but it would be nice to solve the actual issue

It would take an upstream fix (my guess is lhs files are relying on GHCi and flags aren't properly set).

If you want, I can work on a less invasive solution: disabling only doctests, or avoiding lhs.

Let me know what would be better.

Between the options, I would prefer disabling only doctests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants