Skip to content

Commit

Permalink
Digital Credential: DigitalCredentialsRequest's request member is now…
Browse files Browse the repository at this point in the history
… called data

https://bugs.webkit.org/show_bug.cgi?id=279933
rdar://136714291

Reviewed by Abrar Rahman Protyasha and Alex Christensen.

The `request` member of IdentityRequestProvider is now called data.

Spec change:
WICG/digital-credentials#165

* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/dc-types.ts:
* LayoutTests/imported/w3c/web-platform-tests/digital-credentials/support/helper.js:
(makeIdentityRequestProvider):
* Source/WebCore/Modules/identity/IdentityRequestProvider.h:
* Source/WebCore/Modules/identity/IdentityRequestProvider.idl:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/288669@main
  • Loading branch information
marcoscaceres committed Jan 9, 2025
1 parent 5a8e807 commit 42df611
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export type CredentialMediationRequirement =
*/
export interface IdentityRequestProvider {
protocol: string;
request: object;
data: object;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ export function makeGetOptions(providersToUse = ["default"], mediation = "requir
/**
*
* @param {string} protocol
* @param {object} request
* @param {object} data
* @returns {IdentityRequestProvider}
*/
function makeIdentityRequestProvider(protocol = "protocol", request = {}) {
function makeIdentityRequestProvider(protocol = "protocol", data = {}) {
return {
protocol,
request,
data,
};
}

Expand Down
2 changes: 1 addition & 1 deletion Source/WebCore/Modules/identity/IdentityRequestProvider.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace WebCore {

struct IdentityRequestProvider {
IdentityCredentialProtocol protocol;
OpenID4VPRequest request;
OpenID4VPRequest data;
};

} // namespace WebCore
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@

dictionary IdentityRequestProvider {
required IdentityCredentialProtocol protocol;
required OpenID4VPRequest request;
required OpenID4VPRequest data;
};
Original file line number Diff line number Diff line change
Expand Up @@ -6377,7 +6377,7 @@ struct WebCore::OpenID4VPRequest {

[Nested] struct WebCore::IdentityRequestProvider {
WebCore::IdentityCredentialProtocol protocol;
WebCore::OpenID4VPRequest request;
WebCore::OpenID4VPRequest data;
};

struct WebCore::DigitalCredentialRequestOptions {
Expand Down

0 comments on commit 42df611

Please sign in to comment.