Remove unnecessary Hash#compact call

marcoroth · Aug 22, 2022 · 325a910 · 325a910
1 parent d388611
commit 325a910
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/helpers/turbo/streams/action_helper.rb b/app/helpers/turbo/streams/action_helper.rb
@@ -15,9 +15,9 @@ def turbo_stream_action_tag(action, target: nil, targets: nil, template: nil, **
     template = action.to_sym == :remove ? "" : tag.template(template.to_s.html_safe)
 
     if target = convert_to_turbo_stream_dom_id(target)
-      tag.turbo_stream(template, **attributes.merge(action: action, target: target).compact)
+      tag.turbo_stream(template, **attributes.merge(action: action, target: target))
     elsif targets = convert_to_turbo_stream_dom_id(targets, include_selector: true)
-      tag.turbo_stream(template, **attributes.merge(action: action, targets: targets).compact)
+      tag.turbo_stream(template, **attributes.merge(action: action, targets: targets))
     else
       raise ArgumentError, "target or targets must be supplied"
     end

diff --git a/test/streams/action_helper_test.rb b/test/streams/action_helper_test.rb
@@ -15,6 +15,12 @@ class Turbo::ActionHelperTest < ActionCable::Channel::TestCase
     assert_equal stream, turbo_stream_action_tag("append", target: "message_1", template: "Template", hello: "world", foo: "bar")
   end
 
+  test "additional nil attributes" do
+    stream = "<turbo-stream action=\"append\" target=\"message_1\"><template>Template</template></turbo-stream>"
+
+    assert_equal stream, turbo_stream_action_tag("append", target: "message_1", template: "Template", hello: nil, foo: nil)
+  end
+
   test "additional boolean attributes" do
     stream = "<turbo-stream checked=\"checked\" action=\"append\" target=\"message_1\"><template>Template</template></turbo-stream>"