refactor: add typing on semantic version and utils

marcocesarato · Jan 18, 2021 · f0d5f7d · f0d5f7d
1 parent e15b1d5
commit f0d5f7d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/Changelog.php b/src/Changelog.php
@@ -108,7 +108,7 @@ public function generate(InputInterface $input, SymfonyStyle $output): int
             }
 
             // Generate new version code
-            $semver = new SemanticVersion('1.4.0-rc.1');
+            $semver = new SemanticVersion($lastVersion);
             $newVersion = $semver->bump($bumpRelease);
         }
 

diff --git a/src/SemanticVersion.php b/src/SemanticVersion.php
@@ -28,10 +28,8 @@ public function __construct($version)
 
     /**
      * Bump version.
-     *
-     * @param string $release
      */
-    public function bump($release): string
+    public function bump(string $release): string
     {
         $version = $this->getVersion();
 

diff --git a/src/Utils.php b/src/Utils.php
@@ -8,12 +8,8 @@ class Utils
 {
     /**
      * Clean string removing double spaces and trim.
-     *
-     * @param $string
-     *
-     * @return string
      */
-    public static function clean($string)
+    public static function clean(string $string): string
     {
         $string = trim($string);
 
@@ -24,10 +20,8 @@ public static function clean($string)
      *  Get today date string formatted.
      *
      * @param DateTime $today
-     *
-     * @return string
      */
-    public static function getDateString($date)
+    public static function getDateString(DateTime $date): string
     {
         $months = [
             'January',