fix: add git remote repository url format check

marcocesarato · May 14, 2021 · 56aff63 · 56aff63
1 parent eebfbea
commit 56aff63
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/src/DefaultCommand.php b/src/DefaultCommand.php
@@ -163,7 +163,21 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
             return 1; //Command::FAILURE;
         }
-        $this->validRequirement('Valid git repository detected');
+        $this->validRequirement('Valid git worktree detected');
+
+        // Check git repository
+        if (empty(Repository::parseRemoteUrl())) {
+            $url = Repository::getRemoteUrl();
+            $output->error(
+                'The remote url of your git repository ("' . $url . '") not been parsed correctly. ' .
+                'Please open and issue including your repository url format to make it compatible with this tool: ' .
+                "\nhttps://github.com/marcocesarato/php-conventional-changelog/issues"
+            );
+
+            return 1; //Command::FAILURE;
+        }
+        $this->validRequirement('Valid git remote repository url');
+
         $this->outputStyle->newLine();
 
         // Initialize changelog

diff --git a/src/Git/Repository.php b/src/Git/Repository.php
@@ -236,7 +236,7 @@ protected static function parseShortcodes($content, $shortcodes)
     /**
      * Parse remote url.
      *
-     * @return array|false
+     * @return array
      */
     public static function parseRemoteUrl()
     {
@@ -253,6 +253,6 @@ public static function parseRemoteUrl()
             }
         }
 
-        return false;
+        return [];
     }
 }