Bug 1299001 - Ensure that the toolbox resets the preferences set when…

… it is closed. r=ochameau

This patch fixes a regression which has been likely introduced in the refactoring
we did in Bug 1222047 on Firefox 63.

Differential Revision: https://phabricator.services.mozilla.com/D7523

UltraBlame original commit: 5e5d6abb39afe0a23555db526a5bbbf3d59b4cd9

devtools/client/aboutdebugging/test/browser_addons_debug_webextension_popup.js

@@ -402,6 +402,32 @@ onReadyForOpenPopup
 let
 onPopupCustomMessage
 ;
+is
+(
+Services
+.
+prefs
+.
+getBoolPref
+(
+"
+ui
+.
+popup
+.
+disable_autohide
+"
+)
+false
+"
+disable_autohide
+shoult
+be
+initially
+false
+"
+)
+;
 Management
 .
 on
@@ -1569,16 +1595,47 @@ API
 await
 onToolboxClose
 ;
-ok
+info
 (
-true
 "
 Addon
 toolbox
 closed
 "
 )
 ;
+is
+(
+Services
+.
+prefs
+.
+getBoolPref
+(
+"
+ui
+.
+popup
+.
+disable_autohide
+"
+)
+false
+"
+disable_autohide
+should
+be
+reset
+to
+false
+when
+the
+toolbox
+is
+closed
+"
+)
+;
 await
 uninstallAddon
 (

devtools/client/framework/toolbox.js

@@ -15560,7 +15560,9 @@ preferenceFront
 (
 )
 {
-return
+const
+frontPromise
+=
 this
 .
 target
@@ -15576,6 +15578,51 @@ preference
 "
 )
 ;
+frontPromise
+.
+then
+(
+front
+=
+>
+{
+/
+/
+Set
+the
+_preferenceFront
+property
+to
+allow
+the
+resetPreferences
+toolbox
+method
+/
+/
+to
+cleanup
+the
+preference
+set
+when
+the
+toolbox
+is
+closed
+.
+this
+.
+_preferenceFront
+=
+front
+;
+}
+)
+;
+return
+frontPromise
+;
 }
 /
 /