Bug 1359397 - Don't allow Selection in nodes not in the document; r=m…

…asayuki

This matches the spec and Chrome, and seems to bring us closer to Edge
and WebKit as well.  It also matches our own behavior for addRange(),
which was changed in bug 1341137.

For collapse and selectAllChildren, we match the tests and browsers, but
the spec is incorrect at the time of this writing:
w3c/selection-api#86

The removeAllRanges test hadn't been updated for the spec change.

MozReview-Commit-ID: DTK8283k5IP

UltraBlame original commit: 0bda6393453ef6ca289a37aa723f87f91160c66f

dom/base/Selection.cpp

@@ -14860,6 +14860,70 @@ selection
 return
 ;
 }
+if
+(
+aContainer
+.
+NodeType
+(
+)
+=
+=
+nsIDOMNode
+:
+:
+DOCUMENT_TYPE_NODE
+)
+{
+aRv
+.
+Throw
+(
+NS_ERROR_DOM_INVALID_NODE_TYPE_ERR
+)
+;
+return
+;
+}
+if
+(
+aOffset
+>
+aContainer
+.
+Length
+(
+)
+)
+{
+aRv
+.
+Throw
+(
+NS_ERROR_DOM_INDEX_SIZE_ERR
+)
+;
+return
+;
+}
+if
+(
+!
+HasSameRoot
+(
+aContainer
+)
+)
+{
+/
+/
+Return
+with
+no
+error
+return
+;
+}
 nsCOMPtr
 <
 nsINode
@@ -16938,6 +17002,24 @@ selection
 return
 ;
 }
+if
+(
+!
+HasSameRoot
+(
+aContainer
+)
+)
+{
+/
+/
+Return
+with
+no
+error
+return
+;
+}
 nsresult
 res
 ;
@@ -18829,6 +18911,49 @@ aRv
 {
 if
 (
+aNode
+.
+NodeType
+(
+)
+=
+=
+nsIDOMNode
+:
+:
+DOCUMENT_TYPE_NODE
+)
+{
+aRv
+.
+Throw
+(
+NS_ERROR_DOM_INVALID_NODE_TYPE_ERR
+)
+;
+return
+;
+}
+if
+(
+!
+HasSameRoot
+(
+aNode
+)
+)
+{
+/
+/
+Return
+with
+no
+error
+return
+;
+}
+if
+(
 mFrameSelection
 )
 {
@@ -23041,6 +23166,31 @@ mFrameSelection
 return
 ;
 }
+if
+(
+!
+HasSameRoot
+(
+aAnchorNode
+)
+|
+|
+!
+HasSameRoot
+(
+aFocusNode
+)
+)
+{
+/
+/
+Return
+with
+no
+error
+return
+;
+}
 SelectionBatcher
 batch
 (
@@ -24341,3 +24491,55 @@ nullptr
 )
 {
 }
+bool
+Selection
+:
+:
+HasSameRoot
+(
+nsINode
+&
+aNode
+)
+{
+nsINode
+*
+root
+=
+aNode
+.
+SubtreeRoot
+(
+)
+;
+nsIDocument
+*
+doc
+=
+GetParentObject
+(
+)
+;
+return
+doc
+=
+=
+root
+|
+|
+(
+root
+&
+&
+doc
+=
+=
+root
+-
+>
+GetComposedDoc
+(
+)
+)
+;
+}

dom/base/Selection.h

@@ -1836,6 +1836,30 @@ aPoint
 ;
 /
 /
+We
+are
+not
+allowed
+to
+be
+in
+nodes
+whose
+root
+is
+not
+our
+document
+bool
+HasSameRoot
+(
+nsINode
+&
+aNode
+)
+;
+/
+/
 XXX
 Please
 don

editor/libeditor/tests/test_bug537046.html

@@ -254,13 +254,6 @@
 /
 SimpleTest
 .
-expectAssertions
-(
-1
-)
-;
-SimpleTest
-.
 waitForExplicitFinish
 (
 )