fix(client-electron): use unique id on lists

marcincichocki · Nov 11, 2021 · ebc232a · ebc232a
1 parent a564c34
commit ebc232a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/electron/renderer/components/KeyBind.tsx b/src/electron/renderer/components/KeyBind.tsx
@@ -185,7 +185,7 @@ export const KeyBind = ({
           <KeyBindText>Unbound</KeyBindText>
         ) : (
           selected.map((key, i) => (
-            <Fragment key={i}>
+            <Fragment key={key}>
               {!!i && <KeyCodeSeparator>+</KeyCodeSeparator>}
               <KeyCode>{key}</KeyCode>
             </Fragment>

diff --git a/src/electron/renderer/components/Select.tsx b/src/electron/renderer/components/Select.tsx
@@ -97,7 +97,10 @@ const SelectViewer = ({ options, index }: SelectViewerProps) => (
     <SelectViewerValue>{options[index].name}</SelectViewerValue>
     <SelectViewerOptions>
       {options.map((option, i) => (
-        <SelectViewerOption key={i} active={index === i}></SelectViewerOption>
+        <SelectViewerOption
+          key={option.name}
+          active={index === i}
+        ></SelectViewerOption>
       ))}
     </SelectViewerOptions>
   </SelectViewerWrapper>
@@ -150,8 +153,8 @@ export const Select = ({
   return (
     <SelectWrapper disabled={disabled}>
       <select hidden value={value} onChange={onChange}>
-        {options.map(({ value }, i) => (
-          <option key={i} value={value}></option>
+        {options.map(({ name, value }) => (
+          <option key={name} value={value}></option>
         ))}
       </select>
       <SelectButton onClick={prev} disabled={disabled}>