Feature: Prompt when applying tag on non NTFS drive (files-community#…

…14202)
marcelwgn · Dec 14, 2023 · f65c918 · f65c918
1 parent 609be42
commit f65c918
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 8 deletions.
diff --git a/src/Files.App/Strings/en-US/Resources.resw b/src/Files.App/Strings/en-US/Resources.resw
@@ -3638,6 +3638,12 @@
   <data name="Login" xml:space="preserve">
     <value>Login</value>
   </data>
+  <data name="ErrorApplyingTagContent" xml:space="preserve">
+    <value>Tags are currently only compatible on drives formatted as NTFS.</value>
+  </data>
+  <data name="ErrorApplyingTagTitle" xml:space="preserve">
+    <value>There was an error applying this tag</value>
+  </data>
   <data name="DecompressArchiveHereSmartDescription" xml:space="preserve">
     <value>Extract items from selected archive(s) to current folder for single-item archive, or to new folder for multi-item archive</value>
   </data>

diff --git a/src/Files.App/Utils/FileTags/FileTagsHelper.cs b/src/Files.App/Utils/FileTags/FileTagsHelper.cs
@@ -1,12 +1,8 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
-using Files.App.Helpers;
-using Files.App.Utils.Shell;
-using Files.Shared.Extensions;
-using System;
-using System.Linq;
-using System.Threading.Tasks;
+using Microsoft.UI.Xaml.Controls;
+using Windows.Foundation.Metadata;
 using Windows.Storage;
 using Windows.Storage.FileProperties;
 using IO = System.IO;
@@ -27,7 +23,7 @@ public static string[] ReadFileTag(string filePath)
 			return tagString?.Split(',', StringSplitOptions.RemoveEmptyEntries);
 		}
 
-		public static void WriteFileTag(string filePath, string[] tag)
+		public static async void WriteFileTag(string filePath, string[] tag)
 		{
 			var isDateOk = NativeFileOperationsHelper.GetFileDateModified(filePath, out var dateModified); // Backup date modified
 			var isReadOnly = NativeFileOperationsHelper.HasFileAttribute(filePath, IO.FileAttributes.ReadOnly);
@@ -41,7 +37,21 @@ public static void WriteFileTag(string filePath, string[] tag)
 			}
 			else if (ReadFileTag(filePath) is not string[] arr || !tag.SequenceEqual(arr))
 			{
-				NativeFileOperationsHelper.WriteStringToFile($"{filePath}:files", string.Join(',', tag));
+				var result = NativeFileOperationsHelper.WriteStringToFile($"{filePath}:files", string.Join(',', tag));
+				if (result == false)
+				{
+					ContentDialog dialog = new()
+					{
+						Title = "ErrorApplyingTagTitle".GetLocalizedResource(),
+						Content = "ErrorApplyingTagContent".GetLocalizedResource(),
+						PrimaryButtonText = "Ok".GetLocalizedResource()
+					};
+
+					if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
+						dialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;
+
+					await dialog.TryShowAsync();
+				}
 			}
 			if (isReadOnly) // Restore read-only attribute (#7534)
 			{