forked from ampproject/amp-wp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstracting AMP validators and sanitizers into AMP Library #4
Open
marcelovani
wants to merge
18
commits into
develop
Choose a base branch
from
amp-library
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c241ecd
Use composer instead of submodules
marcelovani 82b4767
Deleted folder
marcelovani e91bc15
Updated folder
marcelovani 599181c
Fixing scripts
marcelovani 807b48f
Speeding up script
marcelovani 60615ff
Run update
marcelovani e79d8f2
Moved files into amp-sanitizer library
marcelovani a95b903
Re-instated includes
marcelovani 2346234
Use autoloader
marcelovani 2cc322b
Resolving dependencies
marcelovani d37e8c3
Reverted commit
marcelovani 17d337c
Updating dependencies
marcelovani 9bca805
Merge branch 'amp-library' of github.com:marcelovani/amp-wp into amp-…
marcelovani b23559c
Use Lullabot AMP library to convert the page
marcelovani e2822a0
Require symfony/console
marcelovani 1c43343
Updated packages
marcelovani 20389cc
Upgraded composer
marcelovani 0b20922
Removed composer.lock
marcelovani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,6 +96,7 @@ function _amp_incorrect_plugin_slug_admin_notice() { | |
add_action( 'admin_notices', '_amp_incorrect_plugin_slug_admin_notice' ); | ||
} | ||
|
||
require_once AMP__DIR__ . '/vendor/autoload.php'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include autoloader |
||
require_once AMP__DIR__ . '/includes/class-amp-autoloader.php'; | ||
AMP_Autoloader::register(); | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The submodule is now pulled via composer and goes to the vendor folder