Skip to content
This repository has been archived by the owner on Jun 19, 2020. It is now read-only.

fixing regressed change - tab should move to next dialog #6

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

marcelltoth
Copy link
Owner

Copy of JedWatson#3930

JedWatson#708

Conventional UX is that a tab switches to a new input. I don't know if this was reverted intentionally, or by accident, but this fixes the problem.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2020

🦋 Changeset is good to go

Latest commit: 9619f6d

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 16, 2020

Deploy preview for boring-cori-feb63e ready!

Built with commit 48cbcc8

https://deploy-preview-6--boring-cori-feb63e.netlify.com

@netlify
Copy link

netlify bot commented Feb 16, 2020

Deploy preview for boring-cori-feb63e ready!

Built with commit 9619f6d

https://deploy-preview-6--boring-cori-feb63e.netlify.com

@srevenant
Copy link

I just pulled in react-select-reborn from npmjs, it doesn't appear to have this fix in yet. Am I missing a step? Thanks for taking point on a new project!

@marcelltoth
Copy link
Owner Author

This has not been merged in yet as you can see.

I temporarily halted work on this project as the original maintainers promised they'll take care of the original repo.

@srevenant
Copy link

Ah, cool. Hopefully they will. It still isn't merged in there either :)

@marcelltoth
Copy link
Owner Author

I really hope so. If not, I will resume working on this, however, but it'd be better for the community if the project wasn't split, so let's hope they keep their promise.

@marcelltoth
Copy link
Owner Author

Still nothing happened in the original repo, so I think we should resume work here.

Thank you for your work @srevenant, it will appear in a new release tomorrow the latest.

@marcelltoth marcelltoth merged commit 56ec0c8 into master Mar 18, 2020
@github-actions github-actions bot mentioned this pull request Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants