Fix decoding of N/A temperatures

marcelblijleven · May 3, 2024 · 143ec25 · 143ec25
1 parent 070be83
commit 143ec25
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/goodwe/sensor.py b/goodwe/sensor.py
@@ -885,7 +885,10 @@ def read_temp(buffer: ProtocolResponse, offset: int = None) -> float:
     if offset is not None:
         buffer.seek(offset)
     value = int.from_bytes(buffer.read(2), byteorder="big", signed=True)
-    return float(value) / 10
+    if (value == 32767):
+        return None
+    else:
+        return float(value) / 10
 
 
 def read_datetime(buffer: ProtocolResponse, offset: int = None) -> datetime:

diff --git a/tests/test_et.py b/tests/test_et.py
@@ -434,7 +434,7 @@ def test_GW6000_EH_runtime_data(self):
         self.assertSensor('backup_ptotal', 0, 'W', data)
         self.assertSensor('ups_load', 0, '%', data)
         self.assertSensor('temperature_air', 60.4, 'C', data)
-        self.assertSensor('temperature_module', 3276.7, 'C', data)
+        self.assertSensor('temperature_module', None, 'C', data)
         self.assertSensor('temperature', 38.6, 'C', data)
         self.assertSensor('function_bit', 256, '', data)
         self.assertSensor('bus_voltage', 380.6, 'V', data)