Prevent local file access by default #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false` option BREAKING CHANGE: Prevent local file access by default to fix a security issue. Please provide the `localUrlAccess: true` option if you want to keep the old behavior but keep your system vulnerable to local file access.
marcbachmann
force-pushed
the
prevent-local-file-access-by-default
branch
4 times, most recently
from
a29aa70
to
d2ad4e8
Compare
marcbachmann
force-pushed
the
prevent-local-file-access-by-default
branch
from
d2ad4e8
to
9d90212
Compare
fakelag
reviewed
May 6, 2021
| @@ -35,6 +35,8 @@ function PDF (html, options) { | |||
| if (this.options.filename) this.options.filename = path.resolve(this.options.filename) | |||
| if (!this.options.phantomPath) this.options.phantomPath = phantomjs && phantomjs.path | |||
| this.options.phantomArgs = this.options.phantomArgs || [] | |||
|
|
|||
| if (this.options.localUrlAccess) this.options.phantomArgs.push('--local-url-access=false') | |||
There was a problem hiding this comment.
Am I crazy or is this inverted? if localUrlAccess is false (which it is by default, for security reasons), this option never gets set for phantomjs to disallow local url access? Are the tests inverted as well?
There was a problem hiding this comment.
hah. oops.
should we push it as fix?
There was a problem hiding this comment.
In the case you didn't already go ahead and fix it, I created a PR here to address this #623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
localUrlAccess: falseoption💥 Breaking Change
Prevent local file access by default to fix a security issue.
Please provide the
localUrlAccess: trueoption if you want to keep the old behaviorbut keep your system vulnerable to local file access.
Not sure this module is even usable without installing phantomjs manually.
On linux you might need to download the executable.
The tests are running locally on macos. I'll publish this as version 3.