-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracepoint.rb to 2.0.0 #68
base: master
Are you sure you want to change the base?
Conversation
Oh, I should mention one thing. In the Ruby library you can select which event you want to monitor. I don't think that's possible in this pure Ruby version. So it just pretends to do so, but is actually monitoring all events. |
I haven't had the time to check the API for tracepoint. Can you |
There you go. |
I've introduced actual automated tests for backports. Could you fix https://travis-ci.org/marcandre/backports/jobs/5226693 ? Also, could you copy MRI's tests and adapt them? There might be some Finally, please squash the commits, unless they are independent. BTW, I'm almost done with a huge refactoring making each backport mostly independent (in the split branch currently), so the last two backports will be simple requires. |
I looked at the test failure and I think something is wrong with the "guard" --I don't see anything wrong with the code. Maybe it is confused b/c it is an I removed the docs, squashed all the commits and forced pushed, so that's done. But it does not include any test from MRI b/c I could not find it. Do you know where it is? |
Cool. The test will fail if including your file issues warnings in verbose mode. The indentation is screwed up because you have tabs in your file... MRI tests are in |
Ah okay. I will do the rest in the morning then. Thanks. |
So I ported over the tests, and as you expected there were some discrepancies due to new 2.0 features like keyword arguments. I adjusted for those with the exception of There are a few other issues remaining:
I will rebase the new changes into a single commit after we address these. |
It's too bad this never made it in. There is no way for it to be 100% compatible with Ruby's implementation b/c some things simply aren't possible in pure Ruby. But it is something like 98% the same. |
Mmm, looks like I completely forgot about this. |
BTW, I've done |
I believe so, yes. |
Ok, I'll have to review the code, squash the commits, and figure out why the build does not pass... |
62e3acd
to
a4075a8
Compare
6739a19
to
51e0116
Compare
Hi, last night I finally reworked my the original TracePoint library to be compatible with Ruby 2.0's new rendition (as I mention in issue #65).
It's not quite finished. Unfortunately I don't have the time to put the final polish on, but it is very close, and it is functional. I left a few TODOs in the code about what's left to work out. There isn't much, the primary thing is the proper definitions of
raised_exception
andreturn_value
. Those are new, and I am not sure how they are (or if they even can be) defined. HTH.