Fix github actions #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why setup-micromamba isn't running, but maybe it's related to the version we are trying to use?
Looks like this changed between micromamba v1 and v2?
Explicitly spell out what pre-commit should do, since it seems like maybe the pre-commit action has been deprecated: https://github.com/pre-commit/action points to https://pre-commit.ci/ and I'm not familiar with these .ci tools
Looks like something isn't compatible with 3.12
3.12 doesn't play nicely with FEISTY yet, forcing tests to use 3.11
It looks like the precommit issues were in the .precommit yaml file, and my updates to linting.yaml slowed the test down quite a bit. We'll try the old action and see if it passes with the updated pre-commit configuration
Explicitly setting up pre-commit takes a while, but it actually runs correctly (unlike the pre-commit action)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why
setup-micromambaisn't running, but maybe it's related to the version we are trying to use?