Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics #403

Closed
wants to merge 4 commits into from
Closed

Improve diagnostics #403

wants to merge 4 commits into from

Commits on May 10, 2022

  1. Actually compute photoC_NO3_TOT_zint_100m 

    This diagnostic was added to the diagnostics list, but never actually computed.
I added an additional near_surface_integral argument to where we compute the
per-autotroph photoC_NO3_zint (full depth integral), and the sum of those
near_surface_integral values is the _100m equivalent.
    @mnlevy1981
    mnlevy1981 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a3dde53 View commit details
    Browse the repository at this point in the history

  2. Change default frequency for pocToFloor 

    frequency was changed from 'none' to 'medium' because this value is useful for
forcing FEISTY and it would be nice to just have it in typical CESM output
    @mnlevy1981
    mnlevy1981 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8dd03e5 View commit details
    Browse the repository at this point in the history

  3. Update py_requirements to avoid newer releases 

    I was seeing an error that was introduced with jinja2 v3.0 in the CI, so I
require <3 in the pip requirements file. In a sandbox, I was then seeing an
error from MarkupSafe and it turns out that was introduced in v2.1 so I require
<2.1 in the pip file.

I also updated the github action to (hopefully) run the Fortran test suite even
if building the documentation fails
    @mnlevy1981
    mnlevy1981 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    2b1353a View commit details
    Browse the repository at this point in the history

  4. Update baseline for call_compute_subroutines 

    a3dde53 changed the value of photoC_NO3_TOT_zint_100m from 0 to the actual
integral that should be computed, and we need those correct values in the
baseline for testing purposes.
    @mnlevy1981
    mnlevy1981 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e592cea View commit details
    Browse the repository at this point in the history