-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply restoring to all tracers #214
Apply restoring to all tracers #214
Conversation
Apply restoring to all tracers, not just PO4, NO3, and SiO3. Computes tendency on its own and then applies restoring, so there is an order-of-operations change on these tendencies (and the ALK tendency depends on the NO3 tendency, so it now gets the pre-restoring tendency).
For testing, I ran a POP
|
One question that has come up is when to add restoring to the tendencies. The
Should the |
This update makes sure interior restoring is applied to ALL tracers; it is done in a manner such that restoring is applied after the budget computations, so those no longer need to be adjusted to subtract out the restoring term. Also cleaned up one change from previous code, reverting back to convention of putting mathematical operator after the continuation character when wrapping lines.
Inadvertently added whitespace at top of document, removed from bottom of document.
As expected, 6b59dca only had round-off level effect on a few of the budget terms:
This came from my one-off tests, will re-run POP tests to make sure nothing breaks unexpectedly and then bring these changes to master. |
Apply restoring to all tracers, not just
PO4
,NO3
, andSiO3
. Computestendency on its own and then applies restoring, so there is an
order-of-operations change on these tendencies (and the
ALK
tendencydepends on the
NO3
tendency, so it now gets the pre-restoring tendency).