TS moduleResolution is now "Bundler" #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, closing this one because I forgot there was already a contribution open for this: #47 |
|
Reopening this because #47 despite its title is not about that |
petrsloup
approved these changes
Oct 31, 2023
jonathanlurie
added a commit
that referenced
this pull request
Oct 31, 2023
* setup full typescript support * primary language exists on construction * first review cleanup * second review cleanup * UP gitignore * UP gitignore * UP typedoc and config * UP the prepare npm script is no longer copying demos to doc * FIX inheritance pattern of some Controls due to ML update * FIX Marker now requires an option object * WIP polyline layer helper * REM log * ADD adding a poliline layer * mock the gpx/kml parser * mock the gpx/kml parser * gpx and kml converters; better prettier support; upgrade packages; vite testing * adjust package lock * cleanup part 1 * cleanup part 2 * comment link error * FIX throwing when the string is not valid XML * FIX gpx/kml now throwing if content was xml but not of gpx/kml kind * ADD a function to convert from either gpx or kml * ADD integrate KML/GPX parser to addPolyline method * DOC added more comment * FIX DOMParser issues due to different behviors in Node (testing) and Browser * ADD demos to use map.addPolyline * ADD addPolyline examples * ENH better examples * ENH linting * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * REM unnecessary @param and @return * REM some unnecessary '?' to option objects * ADD polyline blur and gap width options * ADD dash pattern interpreter into actual dash array * Update src/converters/xml.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH code readability * Update src/converters/xml.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/tools.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH now supporting all the languages supported by OMT * REM geojson-validation * FIX example * Support for Customize language (#58) * ADD visitor language * WIP language logic revamp * ADD language from style metadata * ENH language definition * REM got rid of commented code * ENH adjusted the size of secondary lang with visitor language mode * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH from review * ENH added things from review --------- Co-authored-by: Craig O'Connor <[email protected]> * Add polygon helper (#56) * ADD visitor language * ADD helper for addong polygon from geojson * ADD map.addPolygon * REM some data * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH unused import * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH from review --------- Co-authored-by: Craig O'Connor <[email protected]> * Add minimap control (#54) * first attempt * reduce typescript warnings * reduce typescript warnings * add final todo * zoom ceiling; bounds bug fix; pitch off by default; unique style; simplify; etc. * fix key * simplify typescript * review part 1; cleaner types; better comments * remove zoomCeiling; its essentially minZoom * improve readability of minimap options input * bug fix; adjustments * add style downwind functions; requested changes * slight adjustment * set lang fix * improve types --------- Co-authored-by: Craig O'Connor <[email protected]> * Dev points (#59) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * Dev points (#61) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * FIX typo * TS moduleResolution is now "Bundler" (#62) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * ENH changed TypeScript moduleResolution from Node to Bundler * Update to Maplibre gl v3.5.2 (#63) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * ENH changed TypeScript moduleResolution from Node to Bundler * UP now using Maplibre v3.5.2 (strict) --------- Co-authored-by: Craig O'Connor <[email protected]> Co-authored-by: Craig O'Connor <[email protected]>
jonathanlurie
added a commit
that referenced
this pull request
Nov 1, 2023
* setup full typescript support * primary language exists on construction * first review cleanup * second review cleanup * UP gitignore * UP gitignore * UP typedoc and config * UP the prepare npm script is no longer copying demos to doc * FIX inheritance pattern of some Controls due to ML update * FIX Marker now requires an option object * WIP polyline layer helper * REM log * ADD adding a poliline layer * mock the gpx/kml parser * mock the gpx/kml parser * gpx and kml converters; better prettier support; upgrade packages; vite testing * adjust package lock * cleanup part 1 * cleanup part 2 * comment link error * FIX throwing when the string is not valid XML * FIX gpx/kml now throwing if content was xml but not of gpx/kml kind * ADD a function to convert from either gpx or kml * ADD integrate KML/GPX parser to addPolyline method * DOC added more comment * FIX DOMParser issues due to different behviors in Node (testing) and Browser * ADD demos to use map.addPolyline * ADD addPolyline examples * ENH better examples * ENH linting * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * REM unnecessary @param and @return * REM some unnecessary '?' to option objects * ADD polyline blur and gap width options * ADD dash pattern interpreter into actual dash array * Update src/converters/xml.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH code readability * Update src/converters/xml.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/tools.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH now supporting all the languages supported by OMT * REM geojson-validation * FIX example * Support for Customize language (#58) * ADD visitor language * WIP language logic revamp * ADD language from style metadata * ENH language definition * REM got rid of commented code * ENH adjusted the size of secondary lang with visitor language mode * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH from review * ENH added things from review --------- Co-authored-by: Craig O'Connor <[email protected]> * Add polygon helper (#56) * ADD visitor language * ADD helper for addong polygon from geojson * ADD map.addPolygon * REM some data * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH unused import * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * Update src/Map.ts Co-authored-by: Craig O'Connor <[email protected]> * ENH from review --------- Co-authored-by: Craig O'Connor <[email protected]> * Add minimap control (#54) * first attempt * reduce typescript warnings * reduce typescript warnings * add final todo * zoom ceiling; bounds bug fix; pitch off by default; unique style; simplify; etc. * fix key * simplify typescript * review part 1; cleaner types; better comments * remove zoomCeiling; its essentially minZoom * improve readability of minimap options input * bug fix; adjustments * add style downwind functions; requested changes * slight adjustment * set lang fix * improve types --------- Co-authored-by: Craig O'Connor <[email protected]> * Dev points (#59) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * Dev points (#61) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * FIX typo * TS moduleResolution is now "Bundler" (#62) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * ENH changed TypeScript moduleResolution from Node to Bundler * Update to Maplibre gl v3.5.2 (#63) * WIP point layer helper * WIP better clusters * WIP changed point helper options * ADD color ramps with builtins * WIP simpler set of options * ADD non linear resampling on color ramps * ADD color ramp doc * ADD outline color for points * ADD point outline settings * REM colorRamp arg and use only pointColor instead * DONE Map.addPoint * ADD radius and weight being both zoom and property driven * ADD zoom comensation param to point helper * FIX minmaxzoom and added MapTiler cloud source with uuid * DOC polyline helper section in readme * WIP readme * DOC done with documenting helpers * DOC color ramp doc * DOC fix * DOC * ENH cleaning unused types * ENH updating eslint * FIX dependecy audit * ENH export types and a better style path * ENH refectoring to place the helpers in a dedicated place * ENH changed TypeScript moduleResolution from Node to Bundler * UP now using Maplibre v3.5.2 (strict) * VER v1.2.0 * ADD gh action for formatting and linting during PR * ENH better linting and formatting rules --------- Co-authored-by: Craig O'Connor <[email protected]> Co-authored-by: Craig O'Connor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-131
Read more about "Bundler" TS moduleResolution here