Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map add drop event #2106

Merged
merged 6 commits into from
Oct 24, 2023
Merged

map add drop event #2106

merged 6 commits into from
Oct 24, 2023

Conversation

deyihu
Copy link
Collaborator

@deyihu deyihu commented Oct 13, 2023

fix #2105

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #2106 (84d39e1) into master (dfdb231) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 33.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   83.43%   83.41%   -0.03%     
==========================================
  Files         164      164              
  Lines       18301    18313      +12     
==========================================
+ Hits        15270    15275       +5     
- Misses       3031     3038       +7     
Files Coverage Δ
src/map/Map.js 87.21% <ø> (ø)
src/map/Map.DomEvents.js 85.24% <33.33%> (-5.67%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuzhenn
Copy link
Member

fuzhenn commented Oct 20, 2023

感觉可以直接在 Map.DomEvents.js 中增加对这几个新增事件的注册就可以了,不需要单独实现

@fuzhenn fuzhenn merged commit db128f2 into maptalks:master Oct 24, 2023
1 check passed
@deyihu deyihu deleted the 2105 branch October 24, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map add drop event
3 participants