增加calculate-expression类型 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzhenn
requested changes
Sep 20, 2024
index.js
Outdated
| @@ -258,7 +333,7 @@ export function loadFunctionTypes(obj, argFn) { | |||
| } | |||
| return hit ? multResult : obj; | |||
| } | |||
| var result = { '__fn_types_loaded': true }, | |||
| var result = { fnTypesLoaded: true }, | |||
index.js
Outdated
| const targetVariable = String(parameters.property); | ||
| const expression = parameters.expression; | ||
| const newValue = input; | ||
| console.log('input', input); |
test.js
Outdated
| expect(rgbatoStr(result.markerFill)).to.be(rgbatoStr([0.21176470588235294, 0.21176470588235294, 0.21176470588235294, 1])); | ||
| }); | ||
| }); | ||
| const expect = require('expect.js'); |
There was a problem hiding this comment.
原来的测试用例不应删除，需要还原回来，用例的分类可以这样处理：
- describe方法里的测试集名称，改为概括性的
specs - 用mocha的context方法增加一个子分类
color-interpolate，把原有用例挪到该分类下 - 同样用context方法增加子类
calculate-expression，把新的用例放到该分类下
fuzhenn
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加calculate-expression类型，可以满足属性字段的单次加减乘除运算。本次提交包含处理代码和测试用例