Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Map controls refactoring #13945

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[iOS] Map controls refactoring #13945

wants to merge 3 commits into from

Conversation

beloal
Copy link
Contributor

@beloal beloal commented Nov 11, 2020

No description provided.

@beloal beloal requested a review from Polas November 11, 2020 08:30
@beloal beloal marked this pull request as draft November 11, 2020 08:30
deltachonglee81
deltachonglee81 suggested changes Nov 17, 2020
View reviewed changes
Copy link

@deltachonglee81 deltachonglee81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to be changed

@biodranik
Copy link
Contributor

@beloal а какую проблему должен был решить этот PR?

@beloal
Copy link
Contributor Author

beloal commented Nov 17, 2021

@beloal а какую проблему должен был решить этот PR?

Насколько я помню, идея была в том чтобы затащить все кнопки на карте в один ViewController и по максимуму избавиться от c++ кода в UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltachonglee81 deltachonglee81 deltachonglee81 requested changes

@Polas Polas Awaiting requested review from Polas

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beloal @biodranik @deltachonglee81