Fix fcntl(FD_CLOEXEC) call to be future proof (confluentinc#3467)

mapr · Apr 8, 2022 · 3694a00 · 3694a00
1 parent 6759e13
commit 3694a00
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/rdkafka_broker.c b/src/rdkafka_broker.c
@@ -1946,13 +1946,21 @@ int rd_kafka_socket_cb_generic(int domain,
                                int type,
                                int protocol,
                                void *opaque) {
-        int s;
-        int on = 1;
-        s      = (int)socket(domain, type, protocol);
+        int s = (int)socket(domain, type, protocol);
+#ifdef FD_CLOEXEC
+        int flags;
+#endif
+
         if (s == -1)
                 return -1;
+
 #ifdef FD_CLOEXEC
-        if (fcntl(s, F_SETFD, FD_CLOEXEC, &on) == -1)
+        if ((flags = fcntl(s, F_GETFD)) == -1)
+                fprintf(stderr,
+                        "WARNING: librdkafka: %s: "
+                        "fnctl(F_GETFD) for FD_CLOEXEC failed: %s: ignoring\n",
+                        __FUNCTION__, rd_strerror(errno));
+        else if (fcntl(s, F_SETFD, flags | FD_CLOEXEC) == -1)
                 fprintf(stderr,
                         "WARNING: librdkafka: %s: "
                         "fcntl(FD_CLOEXEC) failed: %s: ignoring\n",