-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass variables to replace tokens in query #809
Conversation
Noticed this is failing currently due to unrelated regression to ndoe v0.10.x support. Please rebase from master once #810 is merged.
[email protected] is now published.
👍 And ideally on OSX as well as Travis. As you know postgres/postgis is a challenging install. I would prefer not to depend on third-party launchpad PPAs that change over time and may break unpredictably. For this reason I would prefer postgres/postgis is installed from mason, which I can update if needed to keep node-mapnik tests passing against different versions. Want to have a look at https://github.com/springmeyer/postgis-mason-install for an example of how to install this on travis? Or provide an alternative strategy? |
28c2fbd
to
656bf5d
Compare
de0cbc3
to
e580452
Compare
I rebased from master, updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
test/vector-tile.postgis.test.js
Outdated
|
||
it('passes variables to replace tokens in query', function(done) { | ||
if (!hasPostgisAvailable) { | ||
this.skip('postgis not availabel'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spelling fix needed: availabel
-> available
.
@rafatower thanks for putting together the testing quickly. Looks great. I am headed on vacation for a week, but I will plan to test this myself and merge when back. |
Sorry I've not gotten to this. I've become too busy with other responsibilities to dive into this code with the attention I feel is needed. This is a very cool feature, but needs testing to ensure it does not break anything in an unintended way. Is there anyone else reading this could provide:
|
Going to merge this into master without testing further. This is a rare exception for me, but the change is primarily tests so this should be safe. Please ping here if any hits any problems due to this change and we'll investigate. |
This PR fixes #679. It comprises the following changes:
mapnik-vector-tile
updated to current master commit (to be changed).Some remarks:
mapnik-vector-tile
is required, otherwise it will fail at build time. @springmeyer do you plan to release a1.4.1
or1.5.0
version anytime soon?Comments & suggestions welcomed.