Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Dependency #61

Merged
merged 10 commits into from
Nov 19, 2024

Conversation

Patrick-Kladek
Copy link
Contributor

Description

We encountered failing builds in our build pipeline after updating to the newest version. We are using Xcode Cloud and every build fails because Utilities.swift can't find MapLibre. I am able to reproduce this issue locally when I clean the build folder but not when building. Not sure why there is difference on Xcode Cloud.

Tasks

  • Include tests (if applicable) and examples (new or edits)
  • If there are any visual changes as a result, include before/after screenshots and/or videos
  • Add #fixes with the issue number that this PR addresses
  • Update any documentation for affected APIs
  • Update the CHANGELOG
  • Add MapLibre as dependency of InternalUtils Package
  • Fix some warnings on the way.

Infos for Reviewer

After adding MapLibre as a dependency to the InternalUtils package I was not able to reproduce this anymore.

Here is a screenshot from Xcode Cloud before my changes:

Screenshot 2024-11-19 at 15 22 14

And locally (before my changes):

Screenshot 2024-11-19 at 15 28 20

@Patrick-Kladek Patrick-Kladek marked this pull request as ready for review November 19, 2024 08:22
@ianthetechie ianthetechie merged commit ba76be3 into maplibre:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants