Add ability to copy to existing mbtiles files #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
reviewed
Jul 21, 2023
upsicleclown
force-pushed
the
mbtiles-copy-to-existing-file
branch
from
8c7670d
to
b3a2cce
Compare
upsicleclown
force-pushed
the
mbtiles-copy-to-existing-file
branch
from
b3a2cce
to
6ed3195
Compare
nyurik
reviewed
Jul 25, 2023
martin-mbtiles/src/mbtiles.rs
Outdated
| }; | ||
|
|
||
| let mut unique_idx_cols = HashSet::new(); | ||
| let query_string = format!( |
There was a problem hiding this comment.
apparently this can actually be done in a "safer" way (the whole point of sqlx as oppose to calling sqlite directly) - https://docs.rs/sqlx-conditional-queries/0.1.3/sqlx_conditional_queries/macro.conditional_query_as.html
Should we try to use that approach? Could be a separate PR though
There was a problem hiding this comment.
This conditional_query_as! macro seems to use the query_as! macro. This query is a PRAGMA query which doesn't work with sqlx macros.
upsicleclown
changed the title
nyurik
reviewed
Jul 27, 2023
lefuturiste
pushed a commit
to lefuturiste/martin
that referenced
this pull request
Aug 26, 2024
* Allow the `dst` in `mbtiles copy <src> <dst>` command to already contain data, merging tilesets * Add `mbtiles copy --on-duplicate (override|ignore|abort)` --------- Co-authored-by: rstanciu <[email protected]> Co-authored-by: Yuri Astrakhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dstinmbtiles copy <src> <dst>command to already contain data, merging tilesetsmbtiles copy --on-duplicate (override|ignore|abort)