Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mbtiles lib, mbtiles tool tests & CI #702

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Jun 3, 2023

  • Broke up martin-mbtiles into multiple files
  • Made all mbtiles functions take a SqliteExecutor -- this way they can be used with any SQLX connection structs - either a pool connection or an individual non-pooled connection.
  • Simplified mbtiles bin a bit - I realized there is really no need to pretty print the output for the single value retrieval. Easier to just dump it to console as is.
  • Bump martin-mbtiles to v0.2.0
  • Minor fixes in tools docs, cargo.toml, and justfile
  • MBTiles tool Integration tests and release publishing

Major thanks to the stackoverflow quick reply by @cafce25 on how to use generic sql executor!

cc: @upsicleclown

* Broke up martin-mbtiles into multiple files
* Made all mbtiles functions take a `SqliteExecutor` -- this way they can be used with any SQLX connection structs - either a pool connection or an individual non-pooled connection.
* Simplified mbtiles bin a bit - I realized there is really no need to pretty print the output for the single value retrieval. Easier to just dump it to console as is.
* Bump martin-mbtiles to v0.2.0
* Minor fixes in tools docs, cargo.toml, and justfile
@nyurik nyurik changed the title Refactor mbtiles lib Refactor mbtiles lib, mbtiles tool tests & CI Jun 3, 2023
@birkskyum
Copy link
Member

Is there changelogs for react e create?

@nyurik nyurik enabled auto-merge (squash) June 3, 2023 22:07
@nyurik
Copy link
Member Author

nyurik commented Jun 3, 2023

Change log is generated by the releases screen in github

@nyurik nyurik merged commit 2cdd373 into maplibre:main Jun 3, 2023
@nyurik nyurik deleted the refactor-mbtiles branch June 3, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants