Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up configuration system to use Clap #415

Merged
merged 9 commits into from
Sep 28, 2022
Merged

Clean up configuration system to use Clap #415

merged 9 commits into from
Sep 28, 2022

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Sep 26, 2022 •
edited
Loading

  • Use latest Clap-derive (currently v4rc, but should be public within a few days)
  • reorganize configuration to streamline different config sources into one Config (using multiple ConfigBuilders)

@nyurik nyurik force-pushed the clap branch 3 times, most recently from ade3860 to 36e7832 Compare September 27, 2022 03:48
@maxammann
Copy link
Contributor

I can review tomorrow evening CET

stepankuzmin
stepankuzmin approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me 👍

@nyurik nyurik merged commit 47ed143 into maplibre:main Sep 28, 2022
@nyurik nyurik deleted the clap branch September 28, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

@maxammann maxammann Awaiting requested review from maxammann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @maxammann @stepankuzmin