chore(tests): re-blessed all tests #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
changed the title
CommanderStorm
changed the title
|
hopefully it will be fixed soon - and we won't need to re-do it again - so might want to postpone this one. mitsuhiko/insta#676 |
|
lets postpone this for a bit - to see if insta fixes it shortly. If not, we will merge. |
|
looks much cleaner, thx! One thing to note is that insta hasn't released the new version yet, but I don't think its a big deal |
nyurik
approved these changes
Dec 13, 2024
|
Considering that dependency updates are done via dependabot, I think merging now and merging the insta bump when it comes avaliable is a good choice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insta currently produces this (quite annoying) warning:
=> this PR re-blesses all files to get rid of it