Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate MbtilesCopier into Clap struct and parameters struct #1071

Closed
nyurik opened this issue Dec 16, 2023 · 0 comments · Fixed by #1072
Closed

Separate MbtilesCopier into Clap struct and parameters struct #1071

nyurik opened this issue Dec 16, 2023 · 0 comments · Fixed by #1072
Labels
mbtiles Anything related to Martin's MBTiles support

Comments

@nyurik
Copy link
Member

nyurik commented Dec 16, 2023

Currently MbtilesCopier is used both internally inside mbtiles to configure tile copier, and for the command line tool. Most of it aligns pretty well, but creates complexities in the corner cases.

Instead, we should separate MbtilesCopier into two structs:

  • MbtilesCopier without the cli feature
  • MbtilesCopierArgs that has almost the same properties, but focuses on the user interface

For example, dst_type will be of type Option<MbtTypeCli> in the MbtilesCopierArgs (currently it is named dst_type_cli, and will be renamed).
@nyurik nyurik added the mbtiles Anything related to Martin's MBTiles support label Dec 16, 2023
@nyurik nyurik mentioned this issue Dec 16, 2023
Merged
nyurik added a commit that referenced this issue Dec 16, 2023
@nyurik
Split Clap code from MbtilesCopier into CopyArgs (#1072)
16fbfa5 
This allows easier reuse of the copy functionality without affecting CLI
commands.

Closes #1071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mbtiles Anything related to Martin's MBTiles support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split Clap code from MbtilesCopier into CopyArgs nyurik/martin
1 participant
@nyurik