Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes geometry type filter #924

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Fixes geometry type filter #924

merged 2 commits into from
Nov 28, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 28, 2024

Launch Checklist

This is a solution to the following issue:

The problem was that the filter needs a geometry but none was supplied.
This fixes this issue.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

Before:
image

After:
image

@HarelM HarelM requested a review from ibesora November 28, 2024 10:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (f5afe41) to head (d01d54d).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #924   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         107      107           
  Lines        4739     4739           
  Branches     1346     1346           
=======================================
  Hits         4397     4397           
  Misses        342      342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 2ed393e into main Nov 28, 2024
6 checks passed
@HarelM HarelM deleted the Fix-geometry-type-filter branch November 28, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants