Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roll angle to stylesheet #858

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Add roll angle to stylesheet #858

merged 7 commits into from
Oct 16, 2024

Conversation

NathanMOlson
Copy link
Contributor

Add Roll Angle

This PR adds roll angle to the stylesheet.

#850
maplibre/maplibre-gl-js#4717
maplibre/maplibre-gl-js#4780

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (2ff61bf) to head (74438ba).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         105      105           
  Lines        4646     4648    +2     
  Branches     1312     1313    +1     
=======================================
+ Hits         4307     4309    +2     
  Misses        339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Oct 15, 2024

@louwers please approve this as well as this is a style spec change.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should indicate SDK support.

@HarelM
Copy link
Collaborator

HarelM commented Oct 15, 2024

Right. You can set it to 5.0 for js.

src/reference/v8.json Outdated Show resolved Hide resolved
@HarelM
Copy link
Collaborator

HarelM commented Oct 15, 2024

@louwers can I merge this?

@HarelM HarelM merged commit a234c9b into maplibre:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants