Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky spec updates #686

Merged
merged 5 commits into from
May 30, 2024
Merged

Sky spec updates #686

merged 5 commits into from
May 30, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented May 30, 2024

Launch Checklist

According to the following discussion and design:

I've added "experimental" to the description.
Fixes #685

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (36a82b2) to head (dd3f829).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files         104      104           
  Lines        4616     4616           
  Branches     1301     1301           
=======================================
  Hits         4273     4273           
  Misses        343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM marked this pull request as ready for review May 30, 2024 13:05
@HarelM HarelM requested review from louwers, neodescis and birkskyum May 30, 2024 13:05
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make that bold if possible. Also maybe add a link to where development can be followed along (and mention MapLibre GL JS).

src/reference/v8.json Outdated Show resolved Hide resolved
@HarelM
Copy link
Collaborator Author

HarelM commented May 30, 2024

I've updated the description.

@HarelM HarelM merged commit 139a225 into main May 30, 2024
6 checks passed
@HarelM HarelM deleted the sky-spec-update branch May 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sky attribute of MapLibre Style Spec may be invalid
3 participants