Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor crates #12

Merged
merged 25 commits into from
Apr 22, 2022
Merged

Refactor crates #12

merged 25 commits into from
Apr 22, 2022

Conversation

maxammann
Copy link
Collaborator

fixes #4

@nyurik
Copy link
Member

nyurik commented Apr 21, 2022

In IntelliJ in settings under Editor / General at the end there are two magic checkmarks that make diffing a bit saner :)

image

@nyurik
Copy link
Member

nyurik commented Apr 21, 2022

I see there are many root dirs with maplibre-... prefix. Would it make sense to simplify those to make it less crowded? The #12 has this list which i think makes the dir structure a bit too crowded: maplibre-android, maplibre-apple, maplibre-benchmark, maplibre-build-tools, maplibre-core, maplibre-example, maplibre-style, maplibre-tilejson, maplibre-web

Instead we could simplify it to just the /android, /apple, /benchmark, /build-tools, /core, /example, /style, /tilejson, /web

I'm not certain what the maplibre dir is - perhaps this one should stay as maplibre unlike all other.

P.S. I just realized it is all described in #4 - i left a comment there as well.

@maxammann
Copy link
Collaborator Author

Discussion in continuing here: #4

@maxammann maxammann merged commit 04ef557 into main Apr 22, 2022
@maxammann maxammann deleted the refactor-cargo branch April 22, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor crate structure
2 participants