Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 16K alignment for Android build #2996

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix 16K alignment for Android build #2996

merged 2 commits into from
Nov 6, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Nov 6, 2024 •
edited
Loading

  • Make sure correct NDK version is used. Using the system NDK version caused alignment issues on new devices with 16K pages.
  • Add alignment check to android-ci.yml.

Closes #2995

@louwers louwers added android github_actions Pull requests that update GitHub Actions code labels Nov 6, 2024
@louwers louwers self-assigned this Nov 6, 2024
@louwers louwers enabled auto-merge (squash) November 6, 2024 16:46
@louwers louwers merged commit 32c1ab1 into maplibre:main Nov 6, 2024
24 of 25 checks passed
@louwers louwers deleted the fix-alignment-android branch November 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgalvan cgalvan cgalvan approved these changes

@artakka artakka Awaiting requested review from artakka

@adrian-cojocaru adrian-cojocaru Awaiting requested review from adrian-cojocaru

@alexcristici alexcristici Awaiting requested review from alexcristici

Assignees

@louwers louwers

Labels
android github_actions Pull requests that update GitHub Actions code
Projects
MapLibre Native Android
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MapLibre crashes on Android 15 page size 16 from version 11.5.2 and above
2 participants
@louwers @cgalvan