Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows to CI tests #2968

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tdcosta100
Copy link
Collaborator

Until now, except for Node-CI, Windows didn't have tests yet. So now I'm adding them, based on Linux-CI. I created a matrix with 4 renderers (OpenGL, EGL, Vulkan and OSMesa), and 2 rendering modes (Legacy and Drawable). Two combinations are disabled:

  • EGL/Drawable (the tests are throwing exceptions, I don't know what causes it or how to fix. More details)
  • Vulkan/Legacy - since this combination does not exist in Linux, I'm doing the same in Windows

I left some considerations on ignored tests, so others can investigate and fix them in the future. Also, some unit and render tests appear to have specific Windows issues (like font rendering, for example, which will always have some differences, and some number precision issues), so I tweaked these cases, but this is not a definitive solution and suggestions are welcome.

Copy link

github-actions bot commented Oct 26, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2968-compared-to-main.txt

Copy link

github-actions bot commented Oct 26, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2968-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2968-compared-to-legacy.txt

Copy link

github-actions bot commented Oct 26, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0105         +0.0101             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2968-compared-to-main.txt

@tdcosta100 tdcosta100 force-pushed the windows-ci branch 3 times, most recently from d909aa5 to 9465a26 Compare October 26, 2024 05:32
test/CMakeLists.txt Outdated Show resolved Hide resolved
@louwers louwers added build Related to build, configuration or CI/CD windows labels Oct 26, 2024
@tdcosta100 tdcosta100 force-pushed the windows-ci branch 3 times, most recently from 3f4a7f8 to b281110 Compare October 26, 2024 17:38
@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build, configuration or CI/CD github_actions Pull requests that update GitHub Actions code windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants