-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows to CI tests #2968
Open
tdcosta100
wants to merge
3
commits into
maplibre:main
Choose a base branch
from
tdcosta100:windows-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Windows to CI tests #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2968-compared-to-main.txt |
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2968-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2968-compared-to-legacy.txt |
Benchmark Results ⚡
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2968-compared-to-main.txt |
tdcosta100
force-pushed
the
windows-ci
branch
3 times, most recently
from
October 26, 2024 05:32
d909aa5
to
9465a26
Compare
louwers
reviewed
Oct 26, 2024
louwers
reviewed
Oct 26, 2024
louwers
reviewed
Oct 26, 2024
louwers
reviewed
Oct 26, 2024
louwers
reviewed
Oct 26, 2024
louwers
reviewed
Oct 26, 2024
louwers
reviewed
Oct 26, 2024
tdcosta100
force-pushed
the
windows-ci
branch
3 times, most recently
from
October 26, 2024 17:38
3f4a7f8
to
b281110
Compare
louwers
reviewed
Oct 26, 2024
tdcosta100
force-pushed
the
windows-ci
branch
9 times, most recently
from
October 28, 2024 20:44
124e79e
to
34387e3
Compare
tdcosta100
force-pushed
the
windows-ci
branch
from
November 5, 2024 03:52
34387e3
to
11404ee
Compare
tdcosta100
force-pushed
the
windows-ci
branch
from
November 11, 2024 01:04
11404ee
to
fc75f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Related to build, configuration or CI/CD
github_actions
Pull requests that update GitHub Actions code
windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, except for Node-CI, Windows didn't have tests yet. So now I'm adding them, based on Linux-CI. I created a matrix with 4 renderers (OpenGL, EGL, Vulkan and OSMesa), and 2 rendering modes (Legacy and Drawable). Two combinations are disabled:
I left some considerations on ignored tests, so others can investigate and fix them in the future. Also, some unit and render tests appear to have specific Windows issues (like font rendering, for example, which will always have some differences, and some number precision issues), so I tweaked these cases, but this is not a definitive solution and suggestions are welcome.