Fix MapSnapshotter #2967
Merged
Fix MapSnapshotter #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
requested changes
Oct 26, 2024
There was a problem hiding this comment.
For me the 'Snapshot Activity' part of the test app works fine before, but when I try out this PR I get:
Failed to create image decoder with message 'unimplemented'
What exactly is broken?
Edit: Actually, it's the 'Map Snapshotter' that doesn't work, but it also doesn't work after this PR...
|
Okay I think we need more MS tests... |
louwers
approved these changes
Oct 29, 2024
|
I agree... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixed #2869.
Frankly I'm not an Android developer, but a proper developer from our company says this line fixes things. He says, "NPE was because before the icon was png, but now it's svg, and you load those differently".