Index buffers reverted to dirty flag instead of timestamps

[alexcristici]

The index buffers were recreated for each drawable even though 2 or more drawables used the same index buffer.

We need to recreate index buffers only when the buffer data is dirty.
New index buffer will be shared through the indexes variable for all drawables that are using it.

This change also fixes the Android emulator crash.

I also removed some unused variables: indexBuffer, attributeBuffers and instanceBuffers.

[github-actions]

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0% -2.43Ki  -0.1% -16.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2927-compared-to-main.txt

[github-actions]

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0% -21.4Ki  -0.0% -5.07Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2927-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.6Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2927-compared-to-legacy.txt

[github-actions]

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0023         -0.0019             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2927-compared-to-main.txt

[louwers]

Could you provide some more context in the PR description?

[alexcristici]

Could you provide some more context in the PR description?

Sure, not ready yet, I thought I created as a draft. I will change now.

[alexcristici]

Ready for review.

[sjg-wdw]

@TimSylvester cool with you?

[mwilsnd]

Looks to be resolved, nice find!

[alexcristici]

Removed workaround for Android emulator crash: #2858.