Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to Java 11 #2799

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Downgrade to Java 11 #2799

merged 3 commits into from
Sep 5, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Sep 4, 2024

Make sure the library can be used with Java 11.

Note that Google recommends always setting the latest targetSdkVersion, which is 34 right now. However, when using SDK 34, Java 17 needs to be used. So we should drop support for Java 11 soonish.

@louwers louwers added the android label Sep 4, 2024
@louwers louwers requested a review from alasram September 4, 2024 16:50
@louwers louwers self-assigned this Sep 4, 2024
@louwers louwers added the build Related to build, configuration or CI/CD label Sep 4, 2024
@louwers louwers closed this Sep 4, 2024
@louwers louwers reopened this Sep 4, 2024
@louwers
Copy link
Collaborator Author

louwers commented Sep 4, 2024

Workflows were failing due to some GitHub issue, retrying.

Copy link

github-actions bot commented Sep 4, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2799-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.6Mi  +422% +25.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2799-compared-to-legacy.txt

Copy link

github-actions bot commented Sep 4, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0024         -0.0028             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2799-compared-to-main.txt

Copy link

github-actions bot commented Sep 5, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +16.4Ki  +0.1% +16.0Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2799-compared-to-main.txt

@louwers louwers merged commit 0863dd0 into maplibre:main Sep 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android build Related to build, configuration or CI/CD
Projects
Development

Successfully merging this pull request may close these issues.

3 participants