Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raster masking bug #2798

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

TimSylvester
Copy link
Collaborator

Index buffer updates weren't setting the dirty flag, and the dirty flag wasn't updating the modified time. The former problem existed before #2629.

@TimSylvester TimSylvester added the bug Something isn't working label Sep 3, 2024
@TimSylvester TimSylvester self-assigned this Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +152  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2798-compared-to-main.txt

Copy link

github-actions bot commented Sep 3, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +216  +0.0%    +480    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2798-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +27% +31.5Mi  +422% +25.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2798-compared-to-legacy.txt

Copy link

github-actions bot commented Sep 3, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0140         -0.0139             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2798-compared-to-main.txt

@TimSylvester TimSylvester merged commit b90b2df into maplibre:main Sep 3, 2024
40 checks passed
@TimSylvester TimSylvester deleted the raster-fix branch September 3, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants